bluesky / ophyd-async

Hardware abstraction for bluesky written using asyncio
https://blueskyproject.io/ophyd-async
BSD 3-Clause "New" or "Revised" License
7 stars 21 forks source link

Add threshold energy & gain setting signals to Pilatus #403

Open DiamondJoseph opened 2 weeks ago

DiamondJoseph commented 2 weeks ago

These configuration signals are not static and want to be captured for i22.

coretl commented 2 weeks ago

Should they be load/saved? Or just captured in read_configuration?

DiamondJoseph commented 2 weeks ago

Just captured, they're SignalR

coretl commented 2 weeks ago

They are RW in EPICS though, so when we start using PVI they will become RW in ophyd-async. At that point should they continue to be just captured and not load/saved?

DiamondJoseph commented 2 weeks ago

AFAIK the Threshold energy is set from the beam energy and shouldn't be overriden, gain setting should be RW actually (it looked like an enum dropdown list)

DiamondJoseph commented 2 weeks ago

So gain setting save/load/read/write, threshold energy read