search

bluesky / ophyd-async

Hardware abstraction for bluesky written using asyncio
https://blueskyproject.io/ophyd-async
BSD 3-Clause "New" or "Revised" License
7 stars 21 forks source link

Pilatus timestamps link/value is not correct #416

Open DiamondJoseph opened 6 days ago

DiamondJoseph commented 6 days ago

Pilatus seems to have 2 "timestamp" fields, /entry/instrument/NDAttributes/NDArrayTimeStamp, which contained N values of (1088256331) (Timestamp 1088256331 corresponds to: 2004/06/26 14:25:31 (?))

coretl commented 6 days ago

This is https://github.com/areaDetector/ADPilatus/pull/18

@jsouter what's the status of this on I22?

jsouter commented 6 days ago

@coretl Looks like the version of ADPilatus being used on I22 is 2-9dls4 (from March 2022), there's a 2-9dls5 but don't think it addresses any timestamping issues. https://github.com/areaDetector/ADPilatus/commit/5a649ceb3392b581a19c005db6584fde73ab6ded This is the change Mark pushed through, I can pull that onto dls-master for ADPilatus and make a new release with it

void asynNDArrayDriver::updateTimeStamps(NDArray *pArray)
 {
     updateTimeStamp(&pArray->epicsTS);
     pArray->timeStamp = pArray->epicsTS.secPastEpoch + pArray->epicsTS.nsec/1.e9;
 }