search

bluesky / ophyd-async

Hardware abstraction for bluesky written using asyncio
https://blueskyproject.io/ophyd-async
BSD 3-Clause "New" or "Revised" License
7 stars 21 forks source link

Adds a panda flyer that is implemented with a pcomp block #430

Open evalott100 opened 5 days ago

evalott100 commented 5 days ago

Closes #375

evalott100 commented 5 days ago

@coretl Should I wait for https://github.com/bluesky/ophyd-async/issues/376 to add a test with flying?

coretl commented 5 days ago

@coretl Should I wait for #376 to add a test with flying?

I think you should be able to do the test and the plan stub without #376, maybe try it and see?

evalott100 commented 3 days ago

@coretl I've added a test that mirrors this:

https://github.com/bluesky/ophyd-async/blob/dbbcf28c53fc92170adbda114a26628bf3f3e76a/tests/panda/test_trigger.py#L28-L33

But I think we should probably remove them, I'm not sure what the purpose of this is (checking an object has the methods defined in the class).

coretl commented 3 days ago

@coretl I've added a test that mirrors this:

https://github.com/bluesky/ophyd-async/blob/dbbcf28c53fc92170adbda114a26628bf3f3e76a/tests/panda/test_trigger.py#L28-L33

But I think we should probably remove them, I'm not sure what the purpose of this is (checking an object has the methods defined in the class).

Not much point in tests like that