Pattern Generator dataset creation is not correct, and has no tests to catch it. - Githubissues

bluesky / ophyd-async

Hardware abstraction for bluesky written using asyncio

https://blueskyproject.io/ophyd-async

BSD 3-Clause "New" or "Revised" License

7 stars 21 forks source link

Pattern Generator dataset creation is not correct, and has no tests to catch it. #432

Open abbiemery opened 4 days ago

abbiemery commented 4 days ago

The changes in #429 broke the pattern generator, and this issue is to get it working again with appropriate system test coverage.

The tests need to cover its use as it would be run using the demo.

Changes required for the init of PatternGenerator:

shape of a frame is [detector_height, detector_width]
shape of the DATA HDF dataset is [1, detector_height, detector_width]
fill value for SUM dataset is -1, not required for the dataset
maxshape for the DATA HDF dataset = [None, detector_height, detector_width]

As in the original code in bluefly https://github.com/dls-controls/bluefly/blob/0ee7ea837d5f74e3cdc69e2315e9beed28dd7766/bluefly/areadetector_sim.py#L55-L68