search

bluesky / ophyd-async

Hardware abstraction for bluesky written using asyncio
https://blueskyproject.io/ophyd-async
BSD 3-Clause "New" or "Revised" License
8 stars 24 forks source link

Some tests fail on 3.12 - and should be failing on older versions #520

Open dperl-dls opened 4 weeks ago

dperl-dls commented 4 weeks ago

In testing the new p4p release I came across some test failures which I think are wrong, in particular tests/core/test_mock_signal_backend.py::test_blocks_during_put

In lines 186 and 187 I believe this should test for "first_value" as the signal shouldn't have changed yet with puts blocked - this works correctly on python 3.12 but not earlier versions.

dperl-dls commented 4 weeks ago

similarly https://github.com/bluesky/ophyd-async/blob/d5da999f7f066fd895c9c278c599ec4977bd61d0/tests/epics/advimba/test_vimba.py#L32 fails, I believe because these sets are not awaited - @jwlodek do you think this is correct?

jwlodek commented 4 weeks ago

Indeed I believe those should be awaited. It's interesting that that would not have been caught in tests before

dperl-dls commented 4 weeks ago

Great. I've fixed these in my python 3.12 branch https://github.com/bluesky/ophyd-async/tree/update_p4p_and_py312 but am waiting on another release of p4p built against numpy 2 for python versions 3.11 and 10 before it can be merged