Make Motor locatable - Githubissues

bluesky / ophyd-async

Hardware abstraction for bluesky written using asyncio

https://blueskyproject.io/ophyd-async

BSD 3-Clause "New" or "Revised" License

12 stars 26 forks source link

Make Motor locatable #527

Closed stan-dot closed 3 months ago

stan-dot commented 3 months ago

          I think:

https://github.com/bluesky/bluesky/pull/1536 delivered a Locatable protocol and updated the relative set plan to use it
ophyd-async Motor doesn't support this protocol yet
ophyd EpicsMotor doesn't support this protocol yet

So that would mean the only thing left to do in this ticket is update ophyd-async Motor and ophyd EpicsMotor to have a locate() method that returns the setpoint and readback

Originally posted by @coretl in https://github.com/bluesky/bluesky/issues/1431#issuecomment-2296161700

stan-dot commented 3 months ago

ERROR: Could not find a version that satisfies the requirement pydantic-numpy (from ophyd-async[dev]) (from versions: none)

branch impacted by the numpy error

stan-dot commented 3 months ago

wondering

when ophyd-async imports bluesky.protocol it's a circular import in a sense
both dataclasses and typeddicts are used at the same time...

coretl commented 3 months ago

1. when ophyd-async imports bluesky.protocol it's a circular import in a sense

Why? ophyd-async import bluesky. bluesky does not import ophyd-async

2. both dataclasses and typeddicts are used at the same time...

Typed dicts to satisfy protocols, dataclasses for things that are internal to ophyd-async

stan-dot commented 3 months ago

ok that makes sense, thanks!