FastCS Eiger: Put system tests in CI - Githubissues

bluesky / ophyd-async

Hardware abstraction for bluesky written using asyncio

https://blueskyproject.io/ophyd-async

BSD 3-Clause "New" or "Revised" License

9 stars 23 forks source link

FastCS Eiger: Put system tests in CI #531

Open DominicOram opened 1 month ago

DominicOram commented 1 month ago

https://github.com/bluesky/ophyd-async/pull/528 introduced some system tests that could be run by manually. We should put these in CI so that we properly catch errors with them. The tests themselves involve a number of different containers running IOCs and the simulator. There are examples of orchestrating containers like this in GH Actions at https://github.com/DiamondLightSource/authz/blob/main/.github/workflows/bundler-code.yml and https://github.com/DiamondLightSource/workflows/blob/main/.github/workflows/kyverno-policy.yaml.

Acceptance Criteria

When code is pushed to GH the Eiger system tests get run
These tests are a pre-requisite to merging PRs
These tests are passing

DominicOram commented 2 weeks ago

One potential issue that we would need to work around is that the simulator container does not currently like running headless as it uses zellij