search

bluesky / ophyd-async

Hardware abstraction for bluesky written using asyncio
https://blueskyproject.io/ophyd-async
BSD 3-Clause "New" or "Revised" License
11 stars 25 forks source link

FastCS Eiger: Allow setting the photon energy and other MX settings #532

Open DominicOram opened 2 months ago

DominicOram commented 2 months ago

When arming the Eiger you need to provide the photon energy and a number of other metadata parameters (https://github.com/DiamondLightSource/dodal/blob/46132f0e066debaf906c1a80dcefca175b3f5c01/src/dodal/devices/eiger.py#L224). As part of https://github.com/bluesky/ophyd-async/pull/528 the signals were put in to do this but it still needs to be done as part of the arm of the eiger.

Acceptance Criteria

coretl commented 2 months ago

Can we do this in the plan as bps.mv commands rather than putting this in arm? I was trying to restrict prepare to things that are common to all detectors, that are needed for the triggering system to know about, rather than expanding it to everything

DominicOram commented 2 months ago

Can we do this in the plan as bps.mv commands rather than putting this in arm? I was trying to restrict prepare to things that are common to all detectors, that are needed for the triggering system to know about, rather than expanding it to everything

See comment at https://github.com/bluesky/ophyd-async/pull/528#discussion_r1723198852.