Make np_datatype property of ShapeProvider rather than final axis

bluesky / ophyd-async

Hardware abstraction for bluesky written using asyncio

https://blueskyproject.io/ophyd-async

BSD 3-Clause "New" or "Revised" License

12 stars 26 forks source link

Make np_datatype property of ShapeProvider rather than final axis #555

Closed DiamondJoseph closed 2 months ago

DiamondJoseph commented 2 months ago

This caught me out while updating dodal to opyhd-async: while the numpy datatype may be useful for deciding how much space to allocate for a given stack of frames, it is decidedly not part of the shape of the frame.

For a currently not ADBaseIO detector (the TetrAMM monitor) this tripped me up as the datatype was not being passed as part of the shape and hence it was looking for a datatype with key 1000.

Closes #554

jwlodek commented 2 months ago

Seems like a cleaner approach, I like it.