search

bluesky / ophyd-async

Hardware abstraction for bluesky written using asyncio
https://blueskyproject.io/ophyd-async
BSD 3-Clause "New" or "Revised" License
11 stars 26 forks source link

add Capture mode signal to Panda DataBlock #604

Closed jsouter closed 1 month ago

jsouter commented 1 month ago

Addresses https://github.com/bluesky/ophyd-async/issues/471

Implemented CaptureMode as an int enum to match what's in PandABlocks-ioc

jwlodek commented 1 month ago

Should we make the enum use the string names for each value, instead of int? Like with https://github.com/bluesky/ophyd-async/blob/1559aa0e451ffc93da46f5a0fdc7cf282def7fab/src/ophyd_async/epics/adcore/_core_io.py#L71

jsouter commented 1 month ago

Should we make the enum use the string names for each value, instead of int? Like with

https://github.com/bluesky/ophyd-async/blob/1559aa0e451ffc93da46f5a0fdc7cf282def7fab/src/ophyd_async/epics/adcore/_core_io.py#L71

Would require a small change to the IOC but that would probably be nicer

evalott100 commented 1 month ago

Should we make the enum use the string names for each value, instead of int? Like with https://github.com/bluesky/ophyd-async/blob/1559aa0e451ffc93da46f5a0fdc7cf282def7fab/src/ophyd_async/epics/adcore/_core_io.py#L71

Would require a small change to the IOC but that would probably be nicer

I think everything's already in place on the pandablocks-ioc and ophyd async epics backend for this.

jsouter commented 1 month ago

Okay, just tested against the lab panda, running a camonitor on the CAPTURE_MODE PV shows it gets set to FOREVER when HDFPanda.writer.open() is awaited.