bluesky / ophyd-async

Hardware abstraction for bluesky written using asyncio
https://blueskyproject.io/ophyd-async
BSD 3-Clause "New" or "Revised" License
11 stars 26 forks source link

Make PVI detail DeviceVectors #624

Closed coretl closed 3 days ago

coretl commented 4 weeks ago
          Could: Is this there because PVI has a standard that says something like "`thing_n` is part of a list of 'thing's on the device"? Or is it more of a loose convention?

Either way, since we get to decide what PVI says, could we make it return a structure rather than a string to make it clear this is the case? Out of scope for this PR obviously, would be a separate issue.

_Originally posted by @callumforrester in https://github.com/bluesky/ophyd-async/pull/594#discussion_r1812340170_

Can do this by using QSRV structures with [n] in them:

    info(Q:group, {
        "$(IOC_NAME=PANDAQSRV):PVI": {
            "value.pulse[1].d": {
                "+channel": "VAL",
                "+type": "plain"
            }
        }
    })

We can make this back compatible with https://github.com/PandABlocks/PandABlocks-ioc/issues/138

stan-dot commented 4 days ago

@coretl not clear what is the use case exactly here. is it just syntactic sugar?

coretl commented 3 days ago

Fixed by #625