search

bluesky / ophyd-async

Hardware abstraction for bluesky written using asyncio
https://blueskyproject.io/ophyd-async
BSD 3-Clause "New" or "Revised" License
11 stars 26 forks source link

FIX: Handle NonSupportedFeature exception for pipes #660

Closed burkeds closed 12 hours ago

burkeds commented 1 day ago

Old tango servers running tango version less than 9 don't support the pipe API or get_pipe_list(). Since we don't support pipes yet anyway, we should handle this exception and move on.

burkeds commented 1 day ago

@coretl It looks like CI is failing here due to type checking error in:

/home/runner/work/ophyd-async/ophyd-async/src/ophyd_async/core/_table.py:49:80

coretl commented 13 hours ago

@coretl It looks like CI is failing here due to type checking error in:

/home/runner/work/ophyd-async/ophyd-async/src/ophyd_async/core/_table.py:49:80

Just fixed in #665

burkeds commented 12 hours ago

@coretl It looks like CI is failing here due to type checking error in: /home/runner/work/ophyd-async/ophyd-async/src/ophyd_async/core/_table.py:49:80

Just fixed in #665

Thanks Tom. It looks like this brings down the coverage though. Since this relies on interacting with an old version of Tango, I am not sure how I could write a test for it.

coretl commented 12 hours ago

It looks like this brings down the coverage though. Since this relies on interacting with an old version of Tango, I am not sure how I could write a test for it.

I don't think I care about this, it's such a small change, I'll merge as is...