search

bluesky / ophyd-epics-devices

https://bluesky.github.io/ophyd-epics-devices
Apache License 2.0
1 stars 1 forks source link

Make a generic areaDetector for HDF streaming #23

Closed coretl closed 1 year ago

coretl commented 1 year ago

Also make the same changes to motor that were made to ophyd.v2.epics_demo.Mover.

Fixes #21, #22

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 98.87% and project coverage change: -0.02 :warning:

Comparison is base (cc586b6) 99.54% compared to head (2722b9d) 99.53%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #23 +/- ## ========================================== - Coverage 99.54% 99.53% -0.02% ========================================== Files 4 4 Lines 222 213 -9 ========================================== - Hits 221 212 -9 Misses 1 1 ``` | [Impacted Files](https://app.codecov.io/gh/bluesky/ophyd-epics-devices/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bluesky) | Coverage Δ | | |---|---|---| | [src/ophyd\_epics\_devices/areadetector.py](https://app.codecov.io/gh/bluesky/ophyd-epics-devices/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bluesky#diff-c3JjL29waHlkX2VwaWNzX2RldmljZXMvYXJlYWRldGVjdG9yLnB5) | `99.35% <98.79%> (-0.05%)` | :arrow_down: | | [src/ophyd\_epics\_devices/motor.py](https://app.codecov.io/gh/bluesky/ophyd-epics-devices/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bluesky#diff-c3JjL29waHlkX2VwaWNzX2RldmljZXMvbW90b3IucHk=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

coretl commented 1 year ago

We're going to ditch the container build when we move to https://github.com/bluesky/python3-pip-skeleton so ignore that CI failure