bluesky / ophyd

hardware abstraction in Python with an emphasis on EPICS
https://blueskyproject.io/ophyd
BSD 3-Clause "New" or "Revised" License
51 stars 79 forks source link

Improve fake epicsmotor #1160

Closed dperl-dls closed 6 months ago

dperl-dls commented 1 year ago

Following yesterday's discussion of Hyperion with @danielballan @DominicOram, here is a half-baked PR for improving FakeEpicsMotor, which just makes it what we do over and over for our unit tests in Hyperion.

After writing this, I thought that it might be better/cleaner/something to handle this at a lower level, though. In particular, I had the idea of giving FakeSignal the ability to propagate sets and puts to it to another FakeSignal and then using that in the setup of the Motor instead.

Welcome any opinions.

danielballan commented 1 year ago

Thanks @dperl-dls! We will take a look.

dperl-dls commented 6 months ago

Closing as we now have a nice sim motor in ophyd-async