bluesky / ophyd

hardware abstraction in Python with an emphasis on EPICS
https://blueskyproject.io/ophyd
BSD 3-Clause "New" or "Revised" License
51 stars 79 forks source link

`PositionerBase` move command, bug or intended? #1184

Open cappel89 opened 7 months ago

cappel89 commented 7 months ago

The PositionerBase method .set takes wait as an argument and calls .move method (with wait). However, the .move from PositionerBase immediately crashes with TypeError: PositionerBase.move() got an unexpected keyword argument 'wait'

It seems that this problem is known- see DocString of PositionerBase.

To me it seems unintuitive that the base class crashes immediately. If the base class is not intended to be used directly, I believe it should be turned into an ABC. Or implement the move method, i.e. as for the PVPositioner.