(Bluesky #1682) add OpenTelemetry tracing to status

bluesky / ophyd

hardware abstraction in Python with an emphasis on EPICS

https://blueskyproject.io/ophyd

BSD 3-Clause "New" or "Revised" License

51 stars 79 forks source link

(Bluesky #1682) add OpenTelemetry tracing to status #1189

Closed dperl-dls closed 4 months ago

dperl-dls commented 7 months ago

To go along with https://github.com/bluesky/bluesky/pull/1724

Adds opentelemetry-api as a dependency
Registers a trace on __init__ of StatusBase objects, ends it when they are marked done, and attaches some metadata to help identify what the status belongs to - this metadata is added for class specific metadata in each subclass
Registers traces on StatusBase.wait()

dperl-dls commented 5 months ago

Hi @mrakitin , thanks for your review, sorry it took me so long to get back to you! The trace is indeed applied to StatusBase, I have updated the PR description to be more clear about this. For e.g. DeviceStatus the device is added as an attribute.

mrakitin commented 4 months ago

@dperl-dls, are the CI failures expected?

dperl-dls commented 4 months ago

@mrakitin yes, they're failing on master, unrelated to these changes. I can run all the tests locally and they pass, but I don't really know what I could do about the NSLS epics IOC containers. I was hoping this would be fixed by now and I could rebase.

mrakitin commented 4 months ago

@dperl-dls, are the CI failures expected?

I think we need to refresh the image https://hub.docker.com/r/nsls2/epics-docker/tags to unblock the tests.