search

bluesky / ophyd

hardware abstraction in Python with an emphasis on EPICS
https://blueskyproject.io/ophyd
BSD 3-Clause "New" or "Revised" License
51 stars 79 forks source link

use provided value of trigger_value #1219

Closed prjemian closed 3 weeks ago

prjemian commented 3 weeks ago

Tested identical change locally at APS as part of https://github.com/aps-8id-dys/bluesky/issues/95 and https://github.com/aps-8id-dys/bluesky/issues/99.

tacaswell commented 3 weeks ago

How hard would it be to add a test for this?

prjemian commented 3 weeks ago

How easy is it to create triggerable Signal that requires a testable value? test matrix should include 1, "1!" (since that is our case, and maybe some other type (maybe bool?).

prjemian commented 3 weeks ago

Probably want it to appear in the documentation, too. This is a great feature and it required some investigation to uncover this capability.

prjemian commented 3 weeks ago

Document a Device's trigger_value kwarg in a separate issue.

prjemian commented 3 weeks ago

CI failure (in one Py3.11 configuration) does not look related to this work:

/home/runner/work/_temp/351d6ed9-ee3e-433a-adbc-efc7e5388f9b.sh: line 1:  3115 Segmentation fault      (core dumped) pytest -k "${TEST_CL}"
ophyd/tests/test_areadetector.py
prjemian commented 3 weeks ago

Kept re-running that test configuration until it passed.