Accept stop documents with no 'reason'.

bluesky / suitcase-specfile

write text file such as output by SPEC

Other

0 stars 8 forks source link

Accept stop documents with no 'reason'. #10

Closed danielballan closed 4 years ago

danielballan commented 4 years ago

The 'reason' key is not required by the schema, and we found some documents at CHX that do not have it.

It's a separate question how we are ending up with documents that have an 'exit_status' other than 'success' by no 'reason'. The RunEngine should be ensuring that. Nonetheless, this suitcase should be tolerant of any document that meets the schema, so this change is correct.

danielballan commented 4 years ago

Yeah, this was actually just an incidental issue that we happened across while fixing the main issue at CHX. An email with DAMA CC-ed is on its way with the full story.