Closed mrakitin closed 5 years ago
If we need these in general, we should add them as dependencies of suitcase-utils[test_fixtures]
, which all suitcases declare as a test dependency. (Then we can just update it in one place.)
But stepping back I don't understand why pytest think it requires pytest-benchmark. We aren't using pytest-benchmark.
I agree with @danielballan on this. I just checked and when I run pytest locally I don't get these warnings so I am a little confused as to why they are required.
If we need these in general, we should add them as dependencies of
suitcase-utils[test_fixtures]
, which all suitcases declare as a test dependency. (Then we can just update it in one place.)
Agree on that.
But stepping back I don't understand why pytest think it requires pytest-benchmark. We aren't using pytest-benchmark.
I am not sure either. I just tried to create a fresh conda environment, installed requirements-dev.txt and then the package itself, and got these warnings again. Is it something specific for Mac?
Closing in favor of https://github.com/NSLS-II/suitcase-utils/pull/11.
There were a couple of notifications while I was trying to run pytest:
I don't think it's harmful to not have these dependencies, but to make pytest happy this PR includes them.