search

bluesky / suitcase-tiff

http://nsls-ii.github.io/suitcase
Other
3 stars 6 forks source link

TST: added missing pytest dependencies #12

Closed mrakitin closed 5 years ago

mrakitin commented 5 years ago

There were a couple of notifications while I was trying to run pytest:

$ pytest
==================================================== test session starts ====================================================
platform darwin -- Python 3.6.7, pytest-3.9.3, py-1.7.0, pluggy-0.8.0
rootdir: /Users/mrakitin/src/mrakitin/DAMA/suitcase-tiff, inifile: pytest.ini
No module named 'pytest_benchmark' is missing
collected 54 items

suitcase/tiff/tests/tests.py ......................................................                                   [100%]
$ pytest
==================================================== test session starts ====================================================
platform darwin -- Python 3.6.7, pytest-3.9.3, py-1.7.0, pluggy-0.8.0
benchmark: 3.2.2 (defaults: timer=time.perf_counter disable_gc=False min_rounds=5 min_time=0.000005 max_time=1.0 calibration_precision=10 warmup=False warmup_iterations=100000)
rootdir: /Users/mrakitin/src/mrakitin/DAMA/suitcase-tiff, inifile: pytest.ini
plugins: benchmark-3.2.2
No module named 'asv' is missing
collected 54 items

I don't think it's harmful to not have these dependencies, but to make pytest happy this PR includes them.

danielballan commented 5 years ago

If we need these in general, we should add them as dependencies of suitcase-utils[test_fixtures], which all suitcases declare as a test dependency. (Then we can just update it in one place.)

But stepping back I don't understand why pytest think it requires pytest-benchmark. We aren't using pytest-benchmark.

awalter-bnl commented 5 years ago

I agree with @danielballan on this. I just checked and when I run pytest locally I don't get these warnings so I am a little confused as to why they are required.

mrakitin commented 5 years ago

If we need these in general, we should add them as dependencies of suitcase-utils[test_fixtures], which all suitcases declare as a test dependency. (Then we can just update it in one place.)

Agree on that.

But stepping back I don't understand why pytest think it requires pytest-benchmark. We aren't using pytest-benchmark.

I am not sure either. I just tried to create a fresh conda environment, installed requirements-dev.txt and then the package itself, and got these warnings again. Is it something specific for Mac?

mrakitin commented 5 years ago

Closing in favor of https://github.com/NSLS-II/suitcase-utils/pull/11.