search

bluesky / suitcase-tiff

http://nsls-ii.github.io/suitcase
Other
2 stars 5 forks source link

API/ENH: Expose TiffWriter.__init__ options. Do not override defaults. #16

Closed danielballan closed 5 years ago

danielballan commented 5 years ago

We previously hard-coded bigtiff=True, but given that our first real user found that this upset the downstream code, I guess we should not override tifffile's default (False) and just make sure to expose the option for users who want BigTIFF format.

danielballan commented 5 years ago

Another way to do this is to accept init_kwargs and save_kwargs as separate dicts. That would be less nice to use, but it would future-proof us against the possibility that they might accept kwargs that that share the same name and thus would collide in the formulation proposed in this PR. I think usability can win this round, particular because tifffile itself mashes these kwargs into one call (tifffile.imsave) and that provides some guarantee that tifffile will avoid introducing colliding kwargs in the future.

DanOlds commented 5 years ago

Representing 100% of your user base thus far, I support this change.

danielballan commented 5 years ago

Ha! I chuckled out loud at that. Thanks, @DanOlds.