search

bluesky / suitcase-tiff

http://nsls-ii.github.io/suitcase
Other
3 stars 6 forks source link

File prefix format tests #26

Closed awalter-bnl closed 5 years ago

awalter-bnl commented 5 years ago

This adds a test of the file_prefix templating to suitcase.tiff_stack

awalter-bnl commented 5 years ago

thanks for the quick review @mrakitin much appreciated.

awalter-bnl commented 5 years ago

I am not sure at all why adding one line (a break to the if statement on line 46) suddenly caused codecov to complain about the 2 lines above. I am open to suggestions on fixing this (short of removing the break, which I think is a good suggestion made by @mrakitin ).

danielballan commented 5 years ago

I have verified with a print statement that those lines are being hitting, so I think have to chalk this up to a bug in coverage itself. Not worth holding up this PR over, anyway.