Closed tacaswell closed 2 years ago
Do we not have CI on these repos anymore?
Do we not have CI on these repos anymore?
We don't have GHA CI here yet. But I can get one here from https://github.com/bluesky/suitcase-tiff/blob/master/.travis.yml.
Thank you for the review @mrakitin ! There were two offsetting bugs:
I just pushed a commit that passes locally for me.
https://github.com/tacaswell/suitcase-tiff/actions/runs/2301445745 <- and CI agrees.
If the descriptors reports a 3D shape (e.g. (1, 2048, 2048)) and the data comes out of the filler with the leading dimension dropped, the tiff series serializer will try to write out each line of the array as its own tiff.
This is because we determined if we needed to "up cast" a 2D array to a 3D array by consulting the descriptor and then iterate over the data assuming it is definitely shaped as (frame, rows, cols).
This adds a warning we can make an error in the future.