Closed awalter-bnl closed 5 years ago
FYI, you may notice that there is a new kwarg stack_images
that has been added, this was done at the request of @stuartcampbell. This allows export, or the serializer, to output the files as one image per file or as one large tiff with many images.
We should discuss if the name of the kwarg makes sense, if we want to use a kwarg or some other solution etc. etc.
It also has working tests that test every possible permutation (except for plan that adds a second descriptor to a stream part of the way through, this requires that I add an method to the ophyd.sim.hw
devices. I am starting that work now.
I have added another plan that tests the one stream, multiple descriptors case.
made the requested changes
I have made some more requested changes, we have one more open comment, regarding how to handle multiple runs. Once their is consensus on that I will make the changes then I think we are good.
:exclamation: No coverage uploaded for pull request base (
master@c97e47b
). Click here to learn what that means. The diff coverage is97.56%
.
@@ Coverage Diff @@
## master #5 +/- ##
=========================================
Coverage ? 54.87%
=========================================
Files ? 4
Lines ? 359
Branches ? 0
=========================================
Hits ? 197
Misses ? 162
Partials ? 0
Impacted Files | Coverage Δ | |
---|---|---|
suitcase/tiff/tests.py | 100% <100%> (ø) |
|
suitcase/tiff/conftest.py | 100% <100%> (ø) |
|
suitcase/tiff/__init__.py | 96.87% <96.87%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c97e47b...e2c7e6a. Read the comment docs.
Travis is green, and I think this is good. Will take one more look through with fresh eyes tomorrow before merging. Thanks, @awalter-bnl!
Thanks @danielballan for getting the Travis ci passing
This adds an export and a serilaizer method, based on the agreed assumption that this will explicitly ignore all non 2D data and the metadata.
This works manually, and I will add some test functions soon.
Closes #4