search

bluesky / suitcase-tiff

http://nsls-ii.github.io/suitcase
Other
2 stars 5 forks source link

FIX: Make artifacts a property to keep it up to date. #7

Closed danielballan closed 5 years ago

licode commented 5 years ago

travis still failed ?

danielballan commented 5 years ago

That's a mystery. Can you dig into this, @awalter-bnl?

awalter-bnl commented 5 years ago

This is a result of a change to suitcase.utils. I will push a fix

codecov-io commented 5 years ago

Codecov Report

Merging #7 into master will increase coverage by 0.05%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
+ Coverage   95.12%   95.18%   +0.05%     
==========================================
  Files           3        3              
  Lines          82       83       +1     
  Branches       14       14              
==========================================
+ Hits           78       79       +1     
  Misses          2        2              
  Partials        2        2
Impacted Files Coverage Δ
suitcase/tiff/__init__.py 93.84% <100%> (+0.09%) :arrow_up:
suitcase/tiff/tests.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eb401cd...c5f7ec7. Read the comment docs.

danielballan commented 5 years ago

Sorry for the trashing. This should be good to go now.