search

bluesky / yaqc-bluesky

A bluesky interface to the yaq instrument control framework.
https://yaq.fyi/
BSD 3-Clause "New" or "Revised" License
8 stars 4 forks source link

Don't define set when not implemented #53

Closed ksunden closed 3 years ago

ksunden commented 3 years ago

The presence of the set attr messes with the recognition as "movable" (as any runtime checks simply look for the presence/absence of the attribute.

I don't think there is any reason to supply set which just raises NotImplementedError, as it is already handled by the has-position class mixin.

tests pass without it as well

untzag commented 3 years ago

Makes perfect sense to me. Thanks!