check against bluesky protocols

bluesky / yaqc-bluesky

A bluesky interface to the yaq instrument control framework.

https://yaq.fyi/

BSD 3-Clause "New" or "Revised" License

8 stars 4 forks source link

Closed untzag closed 3 years ago

untzag commented 3 years ago

Actually type check against newly defined bluesky protocols.

ksunden commented 3 years ago

What does inheriting actually get us?

Its not clear to me why bluesky itself is even a dependency, we don't import it at all (aside from this PR)

The protocols are meant for duck typing, why not add a typed test file and just run mypy on that?

That would resolve all the issues with @property etc as in bluesky/bluesky#1466

untzag commented 3 years ago

I'll open again with a correct implementation.