bluesky / yaqc-bluesky

A bluesky interface to the yaq instrument control framework.
https://yaq.fyi/
BSD 3-Clause "New" or "Revised" License
8 stars 4 forks source link

Integrate fields from the yaq client #68

Closed ksunden closed 2 years ago

ksunden commented 2 years ago

Closes #66

This is an initial implementation, there are some things including about the underlying implementation of fields in yaq that I have questions about smoothing out after working on this.

has-limits

has-position

general comments

ksunden commented 2 years ago

Created as a draft as implementing has served to raise a lot of questions that I would like to reach more of a consensus on before fully finishing this feature.

In other news, I'm pretty confident on the path forward to addressing #67 after working on this and doing a bit of additional looking at bluesky/ophyd internals.

ksunden commented 2 years ago

Test failures are because we are inconsistent in the ecosystem on how we actually define fields... so I think we need to address that before we merge this feature that depends on the field definitions... (also needed to make development of yaqc-qtpy sane)

ksunden commented 2 years ago

Tests pass locally, but rely on new behavior in as yet unreleased yaqc... we will have to pin upon release of yaqc