search

bluesky / yaqc-bluesky

A bluesky interface to the yaq instrument control framework.
https://yaq.fyi/
BSD 3-Clause "New" or "Revised" License
8 stars 4 forks source link

Dependent hardware #72

Closed ksunden closed 2 years ago

ksunden commented 2 years ago

Closes #18

This is an initial implementation paired with a change to yaqd-attune, which are the first (And so far only, to my knowledge) daemons to have dependency relations.

In the future this should likely become a trait and not be a special cased hasattr check, but going quick and dirty for now

I would like to put the keys (regardless of whether connection is successful) somewhere that shows up in the event descriptor doc, just not sure whether that should be in configuration or a custom hints field, maybe? That will be what is used primarily by UIs/plans, such as for our tuning methods.

One question I have is should we make the dependent hardware dict public, rather than private (as currently implemented) to make it explicit that things like plans can reach in?

untzag commented 2 years ago

One question I have is should we make the dependent hardware dict public, rather than private (as currently implemented) to make it explicit that things like plans can reach in?

Yes, I think this should be public.

untzag commented 2 years ago

@ksunden is this worth testing? Maybe just open an issue to add tests later?

ksunden commented 2 years ago

Testing is not super easy, involves setting up several daemons with interconnected configs... doable, but not super trivial... I say push off...