Closed RSDamasceno closed 6 years ago
Thank you for submitting this issue with good layout.
Have you tried reboot once after configuring everything?
Does these logs are captured after you selected text? I think some logs are not captured.
From screenshot, a menu item named "SEND TO LYNKET", it's the first item in one screenshot, and the last item in another screenshot, does that mean you are using sort method and it works?
Do you mean the "Translate" menu is gone? If you disable my module, is this problem still occurring?
I tried on Genymotion simulator with Android 8.0, there's a wired thing, select text first, some items are missing in floating menu, select text again in same place, the missing items are appeared. You can have a try.
Hello,
- 1) Yes.
2) I do not know what might have happened to have sent you missing logs... Anyway I did more new tests this time.
3) See feedback at the end.
4) Yes, "Translate" is what I use the most. Currently it is only shown in Gmail, among the apps I tested. With the module enabled and disabled.
5) I know that. Apparently it is a behavior of Android Oreo, as this occurs with the module disabled as well. You must select a second time to appear more options in some applications.
I tested MiXplorer, XDA Labs, Gmail, Google SMS App, WhatsApp and FastHub ... Follow the link with many logs and some screenshots.
Here: EDITED >
L Tweaks 1.18.1 - Show All Floating Menus [Bug Report]
And a small report:
Gmail: all floating menus appear, sort method works. Expected behavior in all applications. Hope! :raised_hands::pray:
FastHub & XDA Labs: all floating menus does not work, sort method does not work. In both it is necessary to select the text a second time to appear more options.
Google SMS App & WhatsApp: all floating menus does not work, sort method works.
MiXplorer: EDITED v
- a) Explore mode & Text Editor mode: all floating menus does not work, sort method works.
b) Code Editor mode: all floating menus does not work, sort method does not work .
Your link is dead, please check.
Oh, sorry...
I edited my previous post.
After some research, I found it's a bug of Android system itself, I don't know why this obvious bug is still not fixed in master branch.
But I can fix it through Xposed, 8054122dfd67db33af2e2a5223dcf76d0d3504a0, and here's a temporary apk, please try if it's ok. 01.FixAllFloatingAction.apk.zip
In addition, the MiXplorer code editor mode is not a standard text floating action mode, so I can't handle it.
Hi,
FastHub: all floating menus appear but after select a second time. Sort method does not work.
XDA Labs & Magisk Manager (in module description): all floating menus appear at first time. Sort method does not work.
Google SMS App, WhatsApp, Gmail, Google +, Xposed Installer, Via Browser, Chrome, Google Play, YouTube (search bar & comment insertion), Google Music (search bar) & MiXplorer (Explore mode & Text Editor): all works.
FastHub and XDA Labs work fine with sort method on my side. Please install this apk and select text in XDA Labs, and capture logs for me.
Sorry for the delay... Here goes the logs on xda labs, fasthub and magisk manager.
---- 11 de abr de 2018 17:13:26 ----
04-11 17:05:19.496 8904 8904 I Xposed : Load li.lingfeng.ltweaks.xposed.google.XposedYoutubeSetQuality for com.google.android.youtube, with prefs []
04-11 17:05:24.750 2598 2598 I Xposed : Grant permission android.permission.PROVIDE_TRUST_AGENT for li.lingfeng.ltweaks
04-11 17:05:36.810 2598 2598 I Xposed : Grant permission android.permission.PROVIDE_TRUST_AGENT for li.lingfeng.ltweaks
04-11 17:05:36.900 2598 2598 I ActivityManager: Start proc 9058:li.lingfeng.ltweaks/u0a213 for service li.lingfeng.ltweaks/.services.WifiTrustAgent
04-11 17:05:37.106 9058 9058 I Xposed : Load li.lingfeng.ltweaks.xposed.XposedLTweaks for li.lingfeng.ltweaks, with prefs []
04-11 17:06:30.650 9522 9522 I Xposed : Load li.lingfeng.ltweaks.xposed.google.XposedYoutubeSetQuality for com.google.android.youtube, with prefs []
04-11 17:07:27.757 2598 2598 I Xposed : Grant permission android.permission.PROVIDE_TRUST_AGENT for li.lingfeng.ltweaks
04-11 17:07:27.892 2598 2598 I Xposed : Grant permission android.permission.PROVIDE_TRUST_AGENT for li.lingfeng.ltweaks
04-11 17:07:28.110 2598 2598 I Xposed : Grant permission android.permission.PROVIDE_TRUST_AGENT for li.lingfeng.ltweaks
04-11 17:07:38.616 2598 4783 I ActivityManager: START u0 {act=android.intent.action.MAIN cat=[android.intent.category.LAUNCHER] flg=0x10300000 cmp=li.lingfeng.ltweaks/.SettingsActivity} from uid 10125
04-11 17:07:38.984 9058 12181 I li.lingfeng.ltweaks: android::hardware::configstore::V1_0::ISurfaceFlingerConfigs::hasWideColorDisplay retrieved: 0
04-11 17:07:39.135 2598 3420 I ActivityManager: Displayed li.lingfeng.ltweaks/.SettingsActivity: +483ms
04-11 17:07:40.326 9058 9058 I chatty : uid=10213(li.lingfeng.ltweaks) identical 2 lines
04-11 17:07:41.691 2598 9192 I ActivityManager: START u0 {cmp=li.lingfeng.ltweaks/.activities.ListCheckActivity (has extras)} from uid 10213
04-11 17:07:42.111 2598 3420 I ActivityManager: Displayed li.lingfeng.ltweaks/.activities.ListCheckActivity: +404ms
04-11 17:08:15.602 11032 11032 V Utils : ⇢ getAppVersionLookup(context=com.xda.labs.XDALabsApp@bb201b1, uri="li.lingfeng.ltweaks")
04-11 17:08:15.604 11032 11032 V DbCache : ⇢ fingerprintMatch(context=com.xda.labs.XDALabsApp@bb201b1, fingerprint="CB032D5305A00FE207284FB8C1345BC5949941C51922B72349A0A034F1CA7FB7", packageName="li.lingfeng.ltweaks")
04-11 17:08:15.604 11032 11032 V Utils : ⇢ getAppSignature(context=com.xda.labs.XDALabsApp@bb201b1, packageName="li.lingfeng.ltweaks")
04-11 17:08:15.607 11032 11032 V ReleaseChanUtils: ⇢ getBuildInfo(tabType=0, pn="li.lingfeng.ltweaks", dates=[Fri Mar 30 11:44:22 GMT-03:00 2018, Fri Mar 30 11:44:22 GMT-03:00 2018, Wed Mar 28 22:00:13 GMT-03:00 2018], vCs=[0, 0, 25], bIds=[0, 0, 24637], installedVer=25)
04-11 17:08:15.611 11032 11032 D InstalledAppsHelper$DbCache: setInstalled==li.lingfeng.ltweaks outOfDate==false
04-11 17:08:15.614 11032 11032 D Utils : package==li.lingfeng.ltweaks installed version==25 matches package version==-1 true==false
04-11 17:09:19.619 11032 11032 V DbCache : ⇢ fingerprintMatch(context=com.xda.labs.XDALabsApp@bb201b1, fingerprint="CB032D5305A00FE207284FB8C1345BC5949941C51922B72349A0A034F1CA7FB7", packageName="li.lingfeng.ltweaks")
04-11 17:09:19.619 11032 11032 V Utils : ⇢ getAppSignature(context=com.xda.labs.XDALabsApp@bb201b1, packageName="li.lingfeng.ltweaks")
04-11 17:09:19.622 11032 11032 V ReleaseChanUtils: ⇢ getBuildInfo(tabType=0, pn="li.lingfeng.ltweaks", dates=[Fri Mar 30 11:44:22 GMT-03:00 2018, Fri Mar 30 11:44:22 GMT-03:00 2018, Wed Mar 28 22:00:13 GMT-03:00 2018], vCs=[0, 0, 25], bIds=[0, 0, 24637], installedVer=25)
04-11 17:09:19.626 11032 11032 D InstalledAppsHelper$DbCache: setInstalled==li.lingfeng.ltweaks outOfDate==false
04-11 17:09:19.629 11032 11032 D Utils : package==li.lingfeng.ltweaks installed version==25 matches package version==-1 true==false
04-11 17:09:49.082 11032 11032 V DbCache : ⇢ fingerprintMatch(context=com.xda.labs.XDALabsApp@bb201b1, fingerprint="CB032D5305A00FE207284FB8C1345BC5949941C51922B72349A0A034F1CA7FB7", packageName="li.lingfeng.ltweaks")
04-11 17:09:49.082 11032 11032 V Utils : ⇢ getAppSignature(context=com.xda.labs.XDALabsApp@bb201b1, packageName="li.lingfeng.ltweaks")
04-11 17:09:49.086 11032 11032 V ReleaseChanUtils: ⇢ getBuildInfo(tabType=0, pn="li.lingfeng.ltweaks", dates=[Fri Mar 30 11:44:22 GMT-03:00 2018, Fri Mar 30 11:44:22 GMT-03:00 2018, Wed Mar 28 22:00:13 GMT-03:00 2018], vCs=[0, 0, 25], bIds=[0, 0, 24637], installedVer=25)
04-11 17:09:49.091 11032 11032 D InstalledAppsHelper$DbCache: setInstalled==li.lingfeng.ltweaks outOfDate==false
04-11 17:09:49.094 11032 11032 D Utils : package==li.lingfeng.ltweaks installed version==25 matches package version==-1 true==false
---- 11 de abr de 2018 17:13:26 ----
I can't find any useful info from your log, I don't if it doesn't work or log is filtered. Please capture log without filter again for me, and don't forget to do once "select text" in xda app.
The compare between menu texts have problem from your log, I have printed more log, please install and capture log again.
By the way, why you have a Portuguese "translate" menu but others are English?
Most of the time I leave the Portuguese language selected in the system settings, but at some point I change to English. So I added in two languages to build organize the menu in both scenarios.
Ok, I think I know where is wrong, the characters on the floating menu are not same as what they are in LTweaks settings.
Such as these 2 "COPY" "COPY", they look same but actually they are not, if you copy this line into github comment editor, you can see the browser will give you a typo hint on the 2nd COPY, there are many Left-to-right mark and Right-to-left mark in your menu items, I don't know why.
So, copy below words into LTweaks settings should solve your problem, there words are from your log.
"SELECT ALL" "SHARE" "COPY" "CUT"
Copy them with quotation marks, paste into LTweaks settings, and remove quotation marks.
Be careful, when you remove quotation marks, move cursor to right position, and press delete button only once, if quotation mark is not be deleted, that means the invisible character is deleted instead.
All invisible characters should be kept.
That's bizarre!
Is this a problem in ROM, Xposed, XDA/FastHub or L Tweaks itself?
I did what you asked for and it worked.
At first I did not find in the log the correct entry for "PASTE", but I captured a new log and I was able to find (also full of these invisible characters).
Can L Tweaks ignore every character at the end and at the beginning of the sentence, anything other than text? Maybe it would solve this problem.
It's not a good idea to remove these characters, they are useful in some languages.
I decompiled XDA and FastHub found these characters, they are using same library, I guess that's why only they have this problem but others are not.
The characters are in this library, but I didn't find COPY PASTE, maybe they are from system, I didn't investigate it further, it must be same as the library, the developer didn't notice these characters.
My suggestion was not to exclude these characters but to ignore them. I thought of something like find / replace. So you could put all "select all" at the top of the list and the characters that are not visible would still be there.
Avoid flooding the settings of L Tweaks with similar entries. Some applications refused to organize the list as I had defined it before (even with its previous tip).
It was like dog and cat (open app > open menu > save logs > search for the correct term > add the right term in L Tweaks), but now I'm like this:
It's not pretty, I know, but at least I managed to organize the menus in the apps I use the most.
The only place I tried to organize and not get was at L Tweaks. Lol.
Stripped LRM, RLM, space in d0586aa00b518d50676b9e1147f7bc4f4f26b7ae, also add remove function in settings 13a25fee7f496414cb57c86e9e279e714436822f.
Please remove the items which contains invisible characters and see if it's still work.
I think now it is only necessary to ignore uppercase and lowercase letters.
The uppercase and lowercase have already be ignored at first release, doesn't it work?
I don't know... But needed create new entries to organize some entries renowned... ("SEL. TUDO", COLAR (TXT)" & "SEND TO LYNKET")
I tried a lot to reproduce your problem, and found this will be reproduced after changing system language.
You can take a reboot to solve this problem, I guess it's a bug from Android itself.
Normally, my sort and rename method will be called only once, I sort them first, then rename, but it will be called twice after system language is changed. The renamed menus will be given to me to sort again, because they are been renamed at first time, they can't be recognized at second time.
Sorry, I also have this problem without changing system language, so, I did a fix on it, you can remove those redundant settings in next release.
Screenshots HERE!
If you need more logs or tests I can provide it.
.
Xposed logs:
Logs filtered by L Tweaks: