search

blueskyCommunity / aozora

MIT License
108 stars 24 forks source link

Create protocol-benchmarks.md #39

Closed jdlewin closed 2 years ago

amark commented 2 years ago

@gvelez17 will you merge so we can fork & PR again? I don't know how to PR on a PR. :(

jdlewin commented 2 years ago

Are you not able to edit in the branch this PR spun up @amark? Is there something I can do differently in the future?

amark commented 2 years ago

Apparently I'm not smart enough. Even though I tried using your branch, it seems like it just generated an entirely new pull and didn't combine it with this.

So I propose closing this, in favor of (I manually merged the other thread too) with this:

https://github.com/blueskyCommunity/aozora/pull/41

gvelez17 commented 2 years ago

Got it, closed that one, you want to open a new one against master from your new branch and we can get comments & merge it in?

On Sat, Jan 15, 2022 at 10:42 PM Mark Nadal @.***> wrote:

Apparently I'm not smart enough. Even though I tried using your branch, it seems like it just generated an entirely new pull and didn't combine it with this.

So I propose closing this, in favor of (I manually merged the other thread too) with this:

41 https://github.com/blueskyCommunity/aozora/pull/41

— Reply to this email directly, view it on GitHub https://github.com/blueskyCommunity/aozora/pull/39#issuecomment-1013815310, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGDBJ37N6UPPNYXMDAI633UWJLF3ANCNFSM5L7PMMOA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>