blueszhangsh / gperftools

Automatically exported from code.google.com/p/gperftools
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Bashism in install_prefix.m4 #154

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. The generated "configure" script contains bash-ism (test==)
As a result ./configure fails on NetBSD/pkgsrc.
See the patch below.

What version of the product are you using? On what operating system?
google-perftools-1.3

Please provide any additional information below.

--- install_prefix.m4.orig      2009-07-14 11:47:36.109384372 +0300
+++ install_prefix.m4   2009-07-14 11:48:07.771935519 +0300
@@ -1,6 +1,6 @@
 AC_DEFUN([AC_INSTALL_PREFIX],
   [ac_cv_install_prefix="$prefix";
-   if test x"$ac_cv_install_prefix" == x"NONE" ; then
+   if test x"$ac_cv_install_prefix" = x"NONE" ; then
      ac_cv_install_prefix="$ac_default_prefix";
    fi
    AC_DEFINE_UNQUOTED(INSTALL_PREFIX, "$ac_cv_install_prefix",

Original issue reported on code.google.com by a.cheu...@gmail.com on 14 Jul 2009 at 8:50

GoogleCodeExporter commented 9 years ago
Oops!  I can never remember which of = and == is standard sh and which isn't.  
I'll
fix this for the next release.  Thanks for pointing it out.

Original comment by csilv...@gmail.com on 14 Jul 2009 at 9:37

GoogleCodeExporter commented 9 years ago
This is fixed in perftools 1.4, just released.

Original comment by csilv...@gmail.com on 11 Sep 2009 at 6:56