blueszhangsh / protobuf-dt

Automatically exported from code.google.com/p/protobuf-dt
0 stars 0 forks source link

ui plugin depends on test plugin #110

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1.  Load the ui and test projects
2.  Observe that com.google.eclipse.protobuf.ui.commands.CommentNodesFinder 
depends on 
com.google.eclipse.protobuf.junit.util.SystemProperties.lineSeparator()
3.

What is the expected output? What do you see instead?
UI should not depend on Test

What version of the product are you using? On what operating system?
1.0.1

Please provide any additional information below.
Simple fix, just lookup the system line separator directly in 
CommentNodesFinder.

  private static final String LINE_SEPARATOR = System.getProperty("line.separator");

...
        String[] comment = rawComment.split(LINE_SEPARATOR);
...

Original issue reported on code.google.com by compuwar...@gmail.com on 13 Sep 2011 at 6:08

GoogleCodeExporter commented 9 years ago

Original comment by compuwar...@gmail.com on 13 Sep 2011 at 6:09

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by alr...@google.com on 13 Sep 2011 at 9:17

GoogleCodeExporter commented 9 years ago
r18341fe53dfa

Original comment by alr...@google.com on 13 Sep 2011 at 9:24