blueszhangsh / serf

Automatically exported from code.google.com/p/serf
Apache License 2.0
0 stars 0 forks source link

[PATCH] Add Dynamic-Link Library support on Windows #58

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
It's good if we have Dynamic-Link Library support on Windows.

Tested with "libserf - Win32 Release" and "libserf - Win32 Debug", all test
case passed.
Since I have no x64 test box, there maybe have buggy for x64 target.

Please review the patch.

Original issue reported on code.google.com by dongshen...@gmail.com on 15 May 2010 at 8:36

Attachments:

GoogleCodeExporter commented 9 years ago
I have been use VC cross compile x64 target, only one exception:

32 bit OpenSSL use non-std path:

OPENSSL_FLAGS = /I "$(OPENSSL_SRC)\inc32"
OPENSSL_LIBS = "$(OPENSSL_SRC)\out32dll\libeay32.lib" \
               "$(OPENSSL_SRC)\out32dll\ssleay32.lib"

But 64bit OpenSSL use std path:
OPENSSL_FLAGS = /I "$(OPENSSL_SRC)\include"
OPENSSL_LIBS = "$(OPENSSL_SRC)\lib\libeay32.lib" \
               "$(OPENSSL_SRC)\lib\ssleay32.lib"

The attachment is the update patch.

Original comment by dongshen...@gmail.com on 15 May 2010 at 12:59

Attachments:

GoogleCodeExporter commented 9 years ago
Attach bwtp_buckets.c to make file.

Original comment by dongshen...@gmail.com on 15 May 2010 at 1:59

Attachments:

GoogleCodeExporter commented 9 years ago
How is libserf.mak different from serf.mak? Is there any way that we can 
combine these into just one?

Also, I would like to remove the serf_declare.h stuff. Subversion gets along 
just fine without it by using a .DEF 
file. I'm going to add a way to automatically generate that file.

Original comment by gstein on 15 May 2010 at 5:23

GoogleCodeExporter commented 9 years ago
The name rule adopt from apr, libapr.mak generate dynamic-link library,
and apr.mak generate static library.

serf.mak only build native code and static library.

libserf.mak add the extra function, like cross build and generate dynamic-link 
library.

So libserf.mak is super set of serf.mak, we can combine them into just one 
nmake file.

After you fixed build/gen_def.py, I will post a new patch.

Another question, serf.mak force us use depend source location (and we must 
build
them at first), can not support installed pre-build binary packages.

How about only support installed pre-build binary packages when build serf ?

Original comment by dongshen...@gmail.com on 17 May 2010 at 9:17

GoogleCodeExporter commented 9 years ago
We're going to switch to scons and eliminate all the other build systems. I'm 
going to label this as a task for that project.

Original comment by gstein on 13 Jul 2011 at 6:43

GoogleCodeExporter commented 9 years ago
Same as I wrote in issue#50, I can help you to proper write autotools build.
sccons is not the answer.
libtool is the perfect tool to achieve this, once you done this it is very easy 
to maintain.
Please consider.

Original comment by alon.barlev@gmail.com on 5 Oct 2011 at 7:35