search

blueszhangsh / serf

Automatically exported from code.google.com/p/serf
Apache License 2.0
0 stars 0 forks source link

Serf crashes Subversion on fork #93

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Per the mailing list thread at 
http://svn.haxx.se/dev/archive-2012-11/0458.shtml, serf crashes Subversion 
during pool cleanup in certain circumstances which involve forked processes 
(such as during hook execution).

http://subversion.tigris.org/issues/show_bug.cgi?id=4266 tracks this problem on 
the Subversion side, and contains a reference to a specific mail in the 
aforementioned thread which carries a patch to solve the problem.

Original issue reported on code.google.com by cmpilato on 11 Dec 2012 at 9:24

GoogleCodeExporter commented 9 years ago 
Note that the patch referenced in the aforementioned thread may be incomplete, 
not so much functionally as aesthetically.  It tweaks a bit of code which 
follows this ominous comment:

    /* ### this implies buckets cannot cross a fork/exec. desirable?
     *
     * ### hmm. it probably also means that buckets cannot be AROUND
     * ### during a fork/exec. the new process will try to clean them
     * ### up and figure out there are unfreed blocks...
     */

If I understand the point of the patch, it functionally makes this comment 
stale -- but it doesn't amend/remove the comment itself.

Original comment by cmpilato on 9 Jan 2013 at 8:28

GoogleCodeExporter commented 9 years ago 
Fixed in r1714. (change applied, comment updated)

Original comment by gstein on 15 Jan 2013 at 11:50