search

bluet / docker-cronicle-docker

Scheduling dockerized Cronicle cron jobs run in docker container.
MIT License
105 stars 26 forks source link

Running Cronicle setup before importing config? #38

Closed dsturgilljr closed 1 year ago

dsturgilljr commented 1 year ago

I noticed in the entrypoint.sh that the custom config is moved into place after the setup is run. I am building a Cronicle server that uses S3 storage, and I was having issues until I moved the setup after moving the custom config in place. I was just reaching out to see if this was tested with a custom config as I was not able to achieve the desired result without the aforementioned change to the entrypoint.sh.

Looking forward to your response! Thanks!

peterbuga commented 1 year ago

@dsturgilljr it just so happens I had the exact same problem, see this and this PR

my basic fix in current state was to simply mount the config file over the existing one https://github.com/bluet/docker-cronicle-docker/issues/36#issuecomment-1649606447

hopefully @bluet will approve it 🤞

dsturgilljr commented 1 year ago

This is a worthy change. I understand that the config is hot reloaded but having setup run after the custom config is moved into place is important (required really) for external storage to work properly on initial setup.

bluet commented 1 year ago

Merged. Thank you guys! 🎉