This PR fixes the NotImplementedError that occurs when running ProxyBroker from the command line interface (CLI) on Windows with Python 3.8 or higher. The issue is caused by a change in the default event loop policy in Python 3.8 on Windows, which does not support the add_reader method used by ProxyBroker. The fix sets the event loop policy to WindowsSelectorEventLoopPolicy on Windows to resolve the compatibility issue.
Summary of Changes
Added code to set the event loop policy to WindowsSelectorEventLoopPolicy in the proxybroker/cli.py file.
The code is placed at the top of the file, after the import statements.
The fix is only applied on Windows, as the issue does not occur on other platforms.
The fix ensures that the add_reader method is supported by the event loop policy, resolving the NotImplementedError issue.
Fixes #113.
To checkout this PR branch, run the following command in your terminal:
To get Sweep to edit this pull request, leave a comment below or in the code. Leaving a comment in the code will only modify the file but commenting below can change the entire PR.
Description
This PR fixes the
NotImplementedError
that occurs when running ProxyBroker from the command line interface (CLI) on Windows with Python 3.8 or higher. The issue is caused by a change in the default event loop policy in Python 3.8 on Windows, which does not support theadd_reader
method used by ProxyBroker. The fix sets the event loop policy toWindowsSelectorEventLoopPolicy
on Windows to resolve the compatibility issue.Summary of Changes
WindowsSelectorEventLoopPolicy
in theproxybroker/cli.py
file.add_reader
method is supported by the event loop policy, resolving theNotImplementedError
issue.Fixes #113.
To checkout this PR branch, run the following command in your terminal:
To get Sweep to edit this pull request, leave a comment below or in the code. Leaving a comment in the code will only modify the file but commenting below can change the entire PR.