search

bluetech / pcsc-rust

Rust bindings to PC/SC for smart card communication
https://docs.rs/pcsc
MIT License
111 stars 23 forks source link

Bump bitflags to `2.4.2` #49

Closed baloo closed 6 months ago

baloo commented 6 months ago

This removes duplicate dependencies in the tree of crates depending on pcsc.

Sadly this also raises the MSRV to 1.56. I would tend to believe this is acceptable.

bluetech commented 6 months ago

Unfortunately it can't be done because it's a breaking change.

baloo commented 6 months ago

and no plan to introduce a new major release?

bluetech commented 6 months ago

I don't think it's worth it just for that...

On Tue, Mar 12, 2024, at 18:07, Arthur Gautier wrote:

and no plan to introduce a new major release?

— Reply to this email directly, view it on GitHub https://github.com/bluetech/pcsc-rust/pull/49#issuecomment-1992018783, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJKW7Q3XN2T3AE7ZO37VULYX4R3JAVCNFSM6AAAAABEOWWOT6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJSGAYTQNZYGM. You are receiving this because you commented.Message ID: @.***>

baloo commented 6 months ago

Well, this is the only dependency - of a fairly large tree - which is duplicated.

Let me know if you reconsider in the future.