search

bluetiger9 / SmtpClient-for-Qt

An SMTP Client writen in C++ for Qt. Allows applications to send emails (MIME with text, html, attachments, inline files, etc.) via SMTP. Supports SSL and SMTP authentication.
https://github.com/bluetiger9/SmtpClient-for-Qt/wiki
GNU Lesser General Public License v2.1
456 stars 227 forks source link

A few improvements for attachment files #135

Closed bjornthirud-fotoware closed 1 year ago

bjornthirud-fotoware commented 1 year ago

Hello,

Thanks for a great library!

I am, however, proposing a few small improvements to how file attachments are handled:

  1. Non-ascii characters in file names: These are not AFAIK allowed by the RFC but they still occur and it might be better to save them as utf-8 which e.g. gmail and Outlook seems to detect correctly.
  2. Filename in the Content-disposition header as per RFC-2183.
  3. Use QMimeDatabase to provide a better MIME type than application/octet-stream. This is such a simple improvement since QMimeDatabase is there already.

Kind Regards Bjørn Thirud