Refactor/register - Githubissues

bluewave-labs / bluewave-dataroom

The open source DocSend alternative

https://bluewavelabs.ca

GNU Affero General Public License v3.0

6 stars 6 forks source link

Refactor/register #60

Closed SajanGhuman closed 3 weeks ago

SajanGhuman commented 1 month ago

This PR improves over the previous PR with things like code refactoring(Addressing change requests from previous PR), code redundancy and adding email template for forgot password feature.

Implemented:

Reduce count of Prisma instances by initializing Prisma globally and making all files use that instance.
Using only one UUID for generating tokens.
New email template
Email sending is now dynamic. (Note: Emails are only sent to authorized emails since it is still in testing. It will change as we move to production and have a public domain)
More structured approach when returning errors.
Delete app/api/send/route.ts as it was redundant and not needed.

gorkem-bwl commented 1 month ago

Looks good. We previously used MJML (https://mjml.io/) in two of our projects, so if you want to use that framework, that is fine. If not, that is fine as well.

gorkem-bwl commented 1 month ago

A few more tips:

We can also change the "BlueWave Labs" wording to "BlueWave Dataroom".
There will be a documentation center on Gitbook, but I am not sure if we'd have "security tips" when we release 1.0
We can use DataRoom logo that you can pick up from Figma, instead of the BlueWave Labs logo.

SajanGhuman commented 1 month ago

Looks good. We previously used MJML (https://mjml.io/) in two of our projects, so if you want to use that framework, that is fine. If not, that is fine as well.

This looks cool. I will definitely have a in-depth look at this.

SajanGhuman commented 1 month ago

A few more tips:

* We can also change the "BlueWave Labs" wording to "BlueWave Dataroom".

* There will be a documentation center on Gitbook, but I am not sure if we'd have "security tips" when we release 1.0

* We can use [DataRoom logo](https://www.figma.com/design/GLFfhwOQeHmbcflgCTuMKA/DataRoom-(Secure-File-Server)?node-id=68-2018&t=z3vMDyQgCRNv0TdB-1) that you can pick up from Figma, instead of the BlueWave Labs logo.

My goal was to give a general idea of how the email template is going to look like. But as you mentioned, we will have to change a lot of thing before the finalization. And thanks for the logo, I needed that!

gorkem-bwl commented 1 month ago

My goal was to give a general idea of how the email template is going to look like. But as you mentioned, we will have to change a lot of thing before the finalization. And thanks for the logo, I needed that!

Yep, agreed! Thanks! :)