bluewave-labs / bluewave-hrm

The HRM application
https://bluewavelabs.ca
GNU Affero General Public License v3.0
4 stars 2 forks source link

Implement email templates #23

Open gorkem-bwl opened 3 weeks ago

gorkem-bwl commented 3 weeks ago

Implement email templates for the following actions. This requires writing an HTML template with proper wording/sentences.

Signup/sign in related

HRM application related

louisv20 commented 2 weeks ago

Is your project open source?

gorkem-bwl commented 2 weeks ago

@louisv20 yes.

louisv20 commented 2 weeks ago

I am a new developer but I can attempt to implement these changes. I can start with one html file and submit PR for review?

gorkem-bwl commented 2 weeks ago

Sure, go ahead. Make sure you check other email templates and also honor their licenses (eg use templates with a permissive license) before opening a PR. Note that those emails should be in a template format. They better look good, simple and easy to the eyes.

louisv20 commented 2 weeks ago

I've added one email template. It was created with the help of AI so no licensing restrictions. If code is up to par, I can implement the remaining templates.

gorkem-bwl commented 2 weeks ago

Looks good. Go ahead and implement the remaining. Just a note that there might be additional modifications to the templates in the future depending on how the backend will generate them and send.

louisv20 commented 2 weeks ago

I've implemented a total of 18 email templates. Please review PR #26

gorkem-bwl commented 2 weeks ago

I have created a design template for this. Can you implement this one in yours?

Email design template
louisv20 commented 2 weeks ago

You want that template as a separate html file?

zaidi201 commented 2 weeks ago

Yes you can give html file as well

louisv20 commented 2 weeks ago

Ok, I will add to PR #26

louisv20 commented 2 weeks ago

It's done 👍

gorkem-bwl commented 2 weeks ago

Can you add this styling to your templates @louisv20 ?

Email design template

Logo: Enthalpy-logo

louisv20 commented 2 weeks ago

I can add logo and button. I'm not sure how to appropriately implement bullet points and lists into the subject matter Screenshot (399)

gorkem-bwl commented 2 weeks ago

Bullet points and lists are just html elements. Those would be in the template file, and not necessarily in each email.

louisv20 commented 2 weeks ago

Bullet points and lists are just html elements. Those would be in the template file, and not necessarily in each email.

Will something like this work for each email? Screenshot (402)

gorkem-bwl commented 1 week ago

Yes, that would work for each email. Note that you don't have to use styling if there is no need. That template is given as an example.

louisv20 commented 1 week ago

Yes, that would work for each email. Note that you don't have to use styling if there is no need. That template is given as an example.

I've made the necessary changes. Please review to merge.

Gol0DRoger commented 6 days ago

Thanks @louisv20 for resolving this issue! I want to contribute to this issue with my methodology. Please @gorkem-bwl allow me to give my solutions. I'm also familiar with HTML, and javascript. I am happy to answer any follow-up questions.

gorkemcetin commented 6 days ago

Thanks @louisv20 for resolving this issue! I want to contribute to this issue with my methodology. Please @gorkem-bwl allow me to give my solutions. I'm also familiar with HTML, and javascript. I am happy to answer any follow-up questions.

Sure, go ahead Rishab!

Gol0DRoger commented 4 days ago

I have created something valuable to this issue, There is a working video file attached to it. I tried my best efficient methodology to the extent of my knowledge.

https://github.com/bluewave-labs/bluewave-hrm/assets/141852484/0483c15f-7668-4099-8c0b-b1115a9140ff

I look forward to your feedback @gorkemcetin !

gorkem-bwl commented 4 days ago

That looks good, @Gol0DRoger - let me create a Figma design file for this and move from there. It will have tabs on the left for each email, and will separate subject and body as two editors. We also need a list of tags to use here so the end user can know which tags to use (eg. [Company name] or [Last day of the work].

Gol0DRoger commented 4 days ago

Great, Let's see. @gorkem-bwl I am not sure if I would be able to execute all of that, but will try.

gorkem-bwl commented 4 days ago

Can you also remove all the styling from the templates, and use {{ }} for the placeholders? @Gol0DRoger

This way the styling is not in the templates and the editor only accepts text as well. Let's get rid of the HTML elements completely.

gorkem-bwl commented 4 days ago

Example:

Dear {{Employee Name}}

We received a request to reset your password. Please click the link below to reset your password:

{{Reset Link}}

If you did not request a password reset, please ignore this email.

If you have any questions, feel free to contact us at {{Support email}}.

Best, {{Company name}}

Gol0DRoger commented 3 days ago

@gorkem-bwl see this one, I executed the changes. No styling/css. Screenshot 2024-06-27 163914

gorkem-bwl commented 3 days ago

Yes, better looks like this (each and every of them). Need newlines as well. Make sure it is readable.

Gol0DRoger commented 3 days ago

ok fine.

Gol0DRoger commented 2 days ago

I have executed all the changes in all templates and added PR #37 . Please review it and get it merged.

https://github.com/bluewave-labs/bluewave-hrm/assets/141852484/ce1f941b-831a-443f-b137-2519238d44ee

@gorkem-bwl

gorkem-bwl commented 6 hours ago

@bolatein can you come up with a design for this? Each section can be a tab on the left, and contents can go to the right.

@Gol0DRoger we also need to separate the subject and contents of the email. After @bolatein is done with the design, you need to use our Figma design guidelines to come up with a UI design. After the review, we can merge.