search

bluewave-labs / bluewave-onboarding

https://bluewavelabs.ca
GNU Affero General Public License v3.0
30 stars 22 forks source link

PR for Issue#301 #337

Closed d02ev closed 3 weeks ago

d02ev commented 3 weeks ago
  1. Added accessGuard.middleware on all CUD operations on Hints, Popups and Banners. Now, only admins can CUD them.
  2. Updated the FE, so that all the CUD buttons are rendered conditionally based upon the logged in user's role.
  3. Added hintServices.js.
  4. Removed Edit Banner error and Edit Popup error.
  5. Updated Hints page to be able to communicate with the BE.

Screenshots:

  1. Logged in user: admin admin_banner admin_hint admin_popup

  2. Logged in user: member member_banner member_popup_hint

coderabbitai[bot] commented 3 weeks ago

Walkthrough

The pull request introduces substantial modifications across multiple files, focusing on enhancing user role permissions and access control in the backend, along with improvements to frontend components for better state management and user experience. New permissions for the ADMIN role have been added, and middleware for access control has been integrated into various routes. Additionally, frontend components have been refactored to utilize new state management techniques and to conditionally render elements based on user roles.

Changes

File Path Changes Summary
backend/config/settings.js Added permissions: popups, hints, banners for userRole.ADMIN.
backend/src/controllers/banner.controller.js Updated editBanner method: added url, bannerText, and modified validation checks.
backend/src/controllers/popup.controller.js Refactored editPopup method: introduced destructuring for request body parameters.
backend/src/routes/banner.routes.js Added accessGuard middleware to routes for adding, deleting, and editing banners.
backend/src/routes/hint.routes.js Added accessGuard middleware to routes for adding, deleting, and editing hints.
backend/src/routes/popup.routes.js Added accessGuard middleware to routes for popup management.
frontend/src/components/HintPageComponents/... Refactored HintLeftContent component to accept new props and handle state updates directly.
frontend/src/scenes/hints/CreateHintPage.jsx Enhanced functionality for creating/editing hints with new state variables and onSave method.
frontend/src/scenes/hints/HintDefaultPage.jsx Replaced mock hints with dynamic fetching from API; updated deletion logic.
frontend/src/scenes/popup/CreatePopupPage.jsx Minor modifications; retained error handling and state management.
frontend/src/services/bannerServices.js Changed endpoint in getBanners from /banner/banners to /banner/all_banners.
frontend/src/services/hintServices.js Introduced new service functions for managing hints: addHint, editHint, deleteHint, getHints, getHintById.
frontend/src/services/popupServices.js Changed endpoint in getPopups from /popup/popups to /popup/all_popups.
frontend/src/templates/... Various components updated for role-based rendering and state management improvements.
frontend/src/utils/guideHelper.js Modified emitToastError to access error messages from a new structure.
frontend/src/utils/loginHelper.js Updated handleAuthSuccess to include id and role in the payload.

Possibly related issues

Possibly related PRs

Suggested labels

backend, frontend

Suggested reviewers

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): > ‼️ **IMPORTANT** > Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged. - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.