bluewave-labs / bluewave-onboarding

https://bluewavelabs.ca
GNU Affero General Public License v3.0
30 stars 22 forks source link

Register Page Modifications #339

Closed erenfn closed 5 days ago

erenfn commented 2 weeks ago

When the server is first launched and no users exist (you can use getTeamCount service to check this), the first person (admin) who opens the application should see the admin registration page, as shown below:

image

Currently, users are redirected to the login page, which should not happen for the first registering user.

Our registration page currently looks like this:

image

It should be modified for this scenario, one time only.

d02ev commented 2 weeks ago

Hi @erenfn,

I would like to work on this issue. Please assign it to me.

erenfn commented 2 weeks ago

Sure! I assigned it to you.

d02ev commented 2 weeks ago

Hi @erenfn,

Regarding the routing to /login or /register, to fetch if any team exists, the user must be authenticated and this routing is before a user is registered or logged in. How should I handle this ? Is it feasible to make the /count endpoint unguarded ?

erenfn commented 2 weeks ago

Yes, you can remove the authentication for /count endpoint

d02ev commented 2 weeks ago

Hi @erenfn, Please review #343 for this issue.

d02ev commented 1 week ago

@erenfn can you please elaborate more on https://github.com/bluewave-labs/bluewave-onboarding/pull/343#discussion_r1836881236