bluewave-labs / bluewave-onboarding

https://bluewavelabs.ca
GNU Affero General Public License v3.0
22 stars 3 forks source link

56 implementing user logout functionalities #81

Closed uparkalau closed 2 months ago

uparkalau commented 2 months ago

I was still able to add_popups (requires authentication) even though I logged out. Please take a look.

Good point, I have to set an expiration time for token

gorkem-bwl commented 2 months ago

I was still able to add_popups (requires authentication) even though I logged out. Please take a look.

Good point, I have to set an expiration time for token

The token expiration time for uptime manager is 30 days when the user clicks on the 'remember me' button, and 2 hours otherwise:

https://github.com/bluewave-labs/bluewave-uptime/issues/163

uparkalau commented 2 months ago

I was still able to add_popups (requires authentication) even though I logged out. Please take a look. This is because you don't check token during popup endpoints