bluewave-labs / bluewave-uptime

BlueWave Uptime Monitor application
https://uptime-demo.bluewavelabs.ca/
GNU Affero General Public License v3.0
444 stars 54 forks source link

FE - Monitor Sort Order #498

Closed ajhollid closed 1 month ago

ajhollid commented 2 months ago

Currently the monitors cannot be sorted:

image

If we want to enable we can sort on either the client or the backend, with the usual tradeoffs.

Client side

Server side

Skorpios604 commented 2 months ago

Seems like a good idea. Some people might want to sort by which monitors are up or down. Like where that arrow is next to status. Users might intuitively click that thinking that it will sort the monitors for them. It is a very wide spread feature.

gorkem-bwl commented 2 months ago

My take: let's go with the client side and if things got slow with hundreds of servers, we can easily switch (I hope that happens lol). Eventually we'll add filters on top of the table, helping users to view only the up or down monitors

gorkem-bwl commented 2 months ago

Another take: The incidents page consists of more than 2500 entries and client side filtering seems to be fast enough. I am not in a position to compare the amount of data on the table (dashboard) and the table (incidents) but I tend to believe it shouldn't be an issue to go client side here.

ajhollid commented 2 months ago

Alright! Let's do it client side and see how it works, always possible to change later if performance degrades.