bluewave-labs / bluewave-uptime

BlueWave Uptime Monitor application
https://uptime-demo.bluewavelabs.ca/
GNU Affero General Public License v3.0
387 stars 34 forks source link

FE - Loading Spinners for data requests #914

Open ajhollid opened 4 days ago

ajhollid commented 4 days ago

Currently (especially on limited bandwidth) some network requests take some time to process as sometimes a lot of data is being crunched/returned. When this occurs a skeleton is displayed:

image

However it isn't clear from a UI/UX point of view that a request is taking place. It might be nice to display a loading spinner/indicator to show that a network request is taking place

gorkem-bwl commented 4 days ago

That is not due to the lack of CPU power right? I got two alarms today that the CPU load is over 95%.

ajhollid commented 4 days ago

That is not due to the lack of CPU power right? I got two alarms today that the CPU load is over 95%.

I think partially it is, performance is worse on DO vs AWS for sure

ajhollid commented 4 days ago

But we need the spinners anyway just for latency

gorkem-bwl commented 4 days ago

Right, agreed. Maybe we can remove some of the demo servers (and leave the Uptime Manager server with only 20-30 servers to check).

ajhollid commented 4 days ago

Right, agreed. Maybe we can remove some of the demo servers (and leave the Uptime Manager server with only 20-30 servers to check).

Sure, I'll make a smaller list of servers and reset it :+1:

marcelluscaio commented 3 days ago

@ajhollid maybe adding Tanstack Query could help with that. It provides fetch status, so we would get the loading state from there

ajhollid commented 3 days ago

@ajhollid maybe adding Tanstack Query could help with that. It provides fetch status, so we would get the loading state from there

I'm not familiar with this, but I'll have a look at it, always excited about new tools!

A lot of our queries do happen through redux though so we do generally know that if a query is in progress or is successful / rejected.