Open om-3004 opened 1 week ago
Hey, I would like to work on this issue. It would be more intuitive and user-friendly to move it to the settings menu under "Appearance." I'd be happy to work on this if it sounds good! Let me know your thoughts.
@om-3004 @rishavd3v
We're always open to outside contributions! Feel free to open up a pull request any time.
@gorkemcetin is our UI / UX designer so touch base with him RE design decisions and we can go from there!
@gorkemcetin What do you think about this thought?
@gorkemcetin What do you think about this thought?
That makes sense. @rishavd3v would you like to work on it?
@gorkem-bwl yeah, would love to!
Made a PR, @ajhollid @gorkem-bwl please review and let me know if any changes are needed.
Looks good, thanks for the video.
FYI @ajhollid
@rishavd3v do you think you can do a more visual design, like one of those? I can build corresponding Figma files and SVGs.
Another alternative is to use a React library like this one. It's simpler and easier to the eyes: https://github.com/H0rn0chse/dark-mode-toggle
I'm still fairly new to React, so I can't commit to more visual design tasks. However, if you open up issues, I'd be happy to take a look and see if it's something I can work on. It would be a fun way for me to learn.
I'm still fairly new to React, so I can't commit to more visual design tasks. However, if you open up issues, I'd be happy to take a look and see if it's something I can work on. It would be a fun way for me to learn.
You may want to check the link above (dark-mode-toggle) and see if you can implement it, without removing the current implementation (#938). We can then try and see if it is a better looking solution.
Got it! I’ll see if I can implement it.
Got it! I’ll see if I can implement it.
Sounds good!
Whenever you're ready for us to take a look at your implementation just open up a PR 👌
Please have a look at the MUI switches and other MUI components in general as well.
This is the library we use to build all our UI comments so it would be ideal to use this.
@rishavd3v are you still interested in working on this?
Thanks for checking in! I’m still interested in working on this. I’ve been learning and trying to implement it. If it's urgent you can co-assign it to someone.
Not urgent, just wanted to check on the status. Carry on, no rush!
The light/dark mode toggle is currently present at the user profile menu along with the log out button. Rather it should be in the settings menu under appearance.