Closed melpsh closed 6 hours ago
The pull request introduces updates to the ComplianceTracker
component, now renamed to Compliance
. It incorporates a dropdown for project selection, dynamic compliance metrics, and an accordion interface for detailed views. Additionally, a new TableCell
component is added for visual indicators in the table. The layout is enhanced with Material-UI components for improved organization and presentation.
File Path | Change Summary |
---|---|
Clients/src/App.tsx | Imported complianceMetrics and complianceDetails from ComplianceData , passing them as props to the ComplianceTracker component. |
Clients/src/presentation/components/Table/index.css | Commented out padding rules for .MuiTableCell-root , disabling previous styles for table cells. |
Clients/src/presentation/components/Table/index.tsx | Introduced a cellStyle object for consistent table cell styling, enhanced header and row rendering, and added an icon display in row cells. |
Clients/src/presentation/pages/ComplianceTracker/complianceData.ts | Created a new file with structured data exports for complianceMetrics and complianceDetails , including metrics and a table structure for compliance controls. |
Clients/src/presentation/pages/ComplianceTracker/index.tsx | Refactored ComplianceTracker to Compliance , added project selection dropdown, dynamic compliance metrics, and accordion functionality, utilizing Material-UI components. |
π In the land of code where rabbits play,
A table now shines, brightening the day.
With icons and metrics, all in a row,
Compliance is tracked, watch it grow!
So hop along, dear friends, take a glance,
At our new features, letβs all dance! π
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
@MuhammadKhalilzadeh are we going to use the icons from MUI or will we use the icons from our Style Guide on Figma?
@gorkem-bwl Both of theme, but mainly, we export icons from the Figma design in SVG format in the icons directory.
@melpsh Please upload screenshots your your current looks of the UI.
Hi Mohammad, here is a screenshot of the page I implemented.
Also, there is no button associated with SubControlPane in Figma implementation.
Please let me know which button is responsible for opening the subControl. Thank you
@gorkem-bwl Would you please provide more details about how Subcontrol pane
will be opened in Compliance Tracker
page?
Also, there is no button associated with SubControlPane in Figma implementation.
When I click on a row on the main table, the corresponding subcontrol pane will be opened. When the mouse is over a row, the background color will change to #FCFCFC
@gorkemcetin We'll update the data types once we finalize the structure of the data received from the backend. @MuhammadKhalilzadeh, kindly confirm this pull request if you've already completed your review. Thanks for your attention!
@gorkemcetin We'll update the data types once we finalize the structure of the data received from the backend. @MuhammadKhalilzadeh, kindly confirm this pull request if you've already completed your review. Thanks for your attention!
Thank you. I'll work with @Mertcanboyar tomorrow to make sure we finalize the data structure very soon.
I couldn't find the correct icons for the accordion table, so I used placeholder icons for now. I will update them later once I find the correct ones.
Summary by CodeRabbit
New Features
Refactor
Style