Closed MuhammadKhalilzadeh closed 1 week ago
[!CAUTION]
Review failed
The pull request is closed.
The pull request modifies multiple controller files to change how the MOCK_DATA_ON
constant is handled, switching from string comparisons to boolean checks. It also introduces new HTTP GET endpoints for various entities, updates route definitions for consistency, and comments out authentication middleware across several routes, impacting access control. Additionally, the utility functions for project management have been overhauled to focus on direct database interactions instead of mock data.
File Path | Change Summary |
---|---|
Servers/controllers/project.ctrl.ts | Updated MOCK_DATA_ON to boolean checks in functions related to project management. |
Servers/controllers/question.ctrl.ts | Updated MOCK_DATA_ON to boolean checks in functions related to question management. |
Servers/controllers/vendorRisk.ctrl.ts | Updated MOCK_DATA_ON to boolean checks in functions related to vendor risk management. |
Servers/driver/autoDriver.driver.ts | Added new imports and updated insertQuery structure for new mock data tables. |
Servers/endpoints-test/*.http.test.rest | Introduced new HTTP GET endpoints for assessments, controls, projects, project risks, project scopes, questions, subcontrols, subtopics, topics, and vendors. |
Servers/index.ts | Changed route paths for subcontrols and subtopics from camel case to lowercase. |
Servers/routes/*.route.ts | Commented out authenticateJWT middleware from all route handlers, removing authentication requirements for various resources. |
Servers/utils/project.utils.ts | Overhauled utility functions to handle database queries for project management instead of mock data insertion. |
Objective | Addressed | Explanation |
---|---|---|
Replace models in server side (#223) | ✅ |
MOCK_DATA_ON
.Frontend Devs
, documentation
, dependencies
In the server's heart, a change so bright,
Mock data now shines with boolean light.
Endpoints added, routes refined,
Authentication loosened, access aligned.
A rabbit hops through code with glee,
Celebrating changes, wild and free! 🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Addressing to close #223
For all the routes the followings are done:
Summary by CodeRabbit
Release Notes
New Features
Changes
Improvements