search

blueyed / vim-diminactive

Vim plugin to dim inactive windows
339 stars 10 forks source link

ColorColumn removed #5

Closed SimonEbner closed 10 years ago

SimonEbner commented 10 years ago

big fan of your plugin, the only drawback is, that it seems to remove my setting for ColorColumn. :set colorcolum=? return colorcolumn= If I deactivate the plugin, everything's back to normal

blueyed commented 10 years ago

Thanks. Nice to hear that.

Are you using the latest version?

I have made some fixes with regard to colorcolumn a while back already (see issue #3).

blueyed commented 10 years ago

What's your initial colorcolumn setting? You might want to poke around with debugging enabled (https://github.com/blueyed/vim-diminactive/blob/master/plugin/diminactive.vim#L41).

SimonEbner commented 10 years ago

I'm using the latest version of your plugin (commit 46a9e5b73a). My initial colorcolumn looks simply like this: set colorcolumn=80 I'll give the debugging a try and let you know in case I stumple upon the solution. Btw, when I set the colorcolumn after the editor is initialized it works just fine. So I'm guessing the setting is somehow overridden.

SimonEbner commented 10 years ago

I'm very far from a vim expert but it seems that on the initial function call of s:enter, the variable diminactive_orig_cuc is empty and so the colorcolumn setting is reset (https://github.com/blueyed/vim-diminactive/blob/master/plugin/diminactive.vim#L82). Unfortunately I wasn't able to fix the problem.

blueyed commented 10 years ago

The above commit should fix it.

Thanks for reporting and investigating!

SimonEbner commented 10 years ago

awesome, thank you very much