search

blumilksoftware / interns-2022c-internships

Intership programme application made by interns themselves.
MIT License
5 stars 5 forks source link

#109 - assets from public brought back #110

Closed brzozka closed 3 years ago

brzozka commented 3 years ago

This PR should close #109

As mentioned in Issue I didn't pay attention and accepted changes that caused problems in frontend side.

plencka commented 3 years ago

Is the public folder even needed for any technical reason? We separated frontend and backend for a reason, and it seems weird that some front thing is lying around the main repo folder.

I'm not sure if current deploy works purely from cache or if site is build from templates.

I'm not frontend person by any means, but I understood that we either use dist or public, as both seem to serve same purpose. Both folders seem to be mainly for distribution.

brzozka commented 3 years ago

@plencka We didn't need a public folder, but we needed it's content. I moved main html file into template, icons into assets folder and removed public afterwards.